This repository has been archived by the owner on Sep 18, 2021. It is now read-only.
Destroy session in DefaultSmppClient on bind error #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case bind fails the caller wont be able to destroy the created session (if any). In the case of DefaultSmppSession this will cause the WindowMonitor of the sendWindow to detect a missing Window.destroy and log an error about this. This patch destroys the session in cases the session has been created but wont be returned to the caller.
|
Mikael Bung seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case bind fails the caller wont be able to destroy the created
session (if any). In the case of DefaultSmppSession this will
cause the WindowMonitor of the sendWindow to detect a missing
Window.destroy and log an error about this.
This patch destroys the session in cases the session has been
created but wont be returned to the caller.